| commit | dc26bbfaec5ba4153eb5ce5b84d1359f78cf7652 | [log] [tgz] |
|---|---|---|
| author | David Ostrovsky <david@ostrovsky.org> | Wed Jul 06 06:45:43 2016 +0200 |
| committer | Khai Do <zaro0508@gmail.com> | Thu Sep 22 16:12:45 2016 +0200 |
| tree | 2a9b4471637431ae03c1745084126831df5f300b | |
| parent | 4475f68df01109d0a8a709395d17addb97f73436 [diff] |
Label-predicate: Add support for change owner votes
Change owner votes may have special meanings and different workflows
may be enforced for them:
o reject votes by change owner can denote Work In Progress (WIP) changes
o approval votes by change owner can mean multiple things, depending on
project policies:
oo review schould not be done on those changes and the change is
only uploaded for verification purposes on different platform and
architecture combinations
oo auto_merge self approved changes when verification was successful
oo enforcing "non-self approval policy", but not forbidding it to
still be able to self approve changes in emergency cases.
Given that this is exception from the policy, there should be an
easy way to detect this policy violation with native gerrit
predicate
Currently there is no built in way to detect change owner votes.
Having a built in way and not depending on external scripts to detect
change owner votes, would create addition value by allowing to combine
different predicates and use the result in gerrit itself, e.g.
dashboards can skip WIP changes.
This change extends label predicate semantic by adding additional
value for change owner votes: "label,owner". Schema version is bumped
to force reindexing. Label field is renamed to Label2 and query parser
is taught to route to the correct predicate depending on the live index
version.
With this change, change owner votes can be detected and used in
different workflows:
o skip WIP changes, rejected by change owner:
is:open NOT label:Code-Review-2,owner
o skip non reviewable changes, approval by change owner:
is:open NOT label:Code-Review+2,owner
o suggest changes for auto merge: approval by change owner + verify
by the bot (assuming default label set: CRVW + VRFY):
project:foo
branch:master
is:open
is:mergeable
label:Code-Review+2,owner
label:Verified+1,buildbot
NOT label:Code-Review-2
NOT label:Verified-1
o detect changes, that violates "non-self approval policy":
label:Code-Review+2,owner
Change-Id: I56ff6b1416f099dc627794c175aa4c2de3f2db9f
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.