commit | dbbaa13d46b3f628e25317a62d6b0ffc74e8e58c | [log] [tgz] |
---|---|---|
author | Prudhvi Akhil Alahari <prudhvi@codeaurora.org> | Mon May 03 10:20:10 2021 +0530 |
committer | Prudhvi Akhil Alahari <prudhvi@codeaurora.org> | Tue May 04 23:47:55 2021 +0530 |
tree | ac401eaed1c2cad92a70a12699992bad16a15183 | |
parent | 83b32989bcee95f5f5dea1672529db6b6db4956a [diff] |
Fix EqualsLabelPredicate to not fail when calling match() from a plugin Calling match() on the EqualsLabelPredicate returned from ChangeQueryBuilder.parse() in a plugin fails when in the context of an HTTP query. In HTTP query workflow, ChangeData lazyLoad flag is being set to true when certain conditions are met. But in SSH workflow, ChangeData lazyLoad flag is always set to true. Due to this reason, we observe the issue only through a HTTP query. In [1], ChangeControl was modified to use ChangeNotes, but EqualsLabelPredicate wasn't updated to always load ChangeNotes in order to check permissions for approvers. Fix this issue by setting ChangeData lazy load to true within match() in EqualsLabelPredicate. Also write integration tests for Label Predicate to ensure it continues to work as expected. In this test setup, plugin named "my-plugin" defines a --sample switch which calls match() on the predicate received from ChangeQueryBuilder.parse() which parses a Label operator query. [1] Iac176b8e55e https://gerrit-review.googlesource.com/246154 Change-Id: Icd2541fe26c18a8e61ce855862e0c9814a91f5ef
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.