| commit | dbba837672f4651685cb01411b04527f6e07d68d | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Fri Feb 03 11:21:50 2023 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Fri Feb 03 13:51:04 2023 +0000 |
| tree | bfd8972d54d8e4e1de7255078c2b962a17e9d960 | |
| parent | c0a3cc03284b55bc164b174b4a3822f67161d30e [diff] |
Fix IllegalArgumentException for % that is not part of an encoded char URLs use percentage encoding which replaces unsafe ASCII characters with a '%' followed by two hexadecimal digits. If there is '%' that is not followed by two hexadecimal digits Url.decode(String) and the code in KeyUtil.decode fail with an IllegalArgumentException. To prevent this replace any '%' that is not followed by two hexadecimal digits by "%25", which is the URL encoding for '%', before decoding. Without this fix users can trigger 500 internal server errors in Gerrit by providing invalid strings for URL parameters (e.g. an invalid project name for the ListAccess REST endpoint or using an invalid name in a change identifier). For context see: https://stackoverflow.com/questions/6067673/urldecoder-illegal-hex-characters-in-escape-pattern-for-input-string Release-Notes: Fixed parsing of URL parameters that contain a '%' that is not part of an encoded character Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I78ba7f34ea1ca511b55889a8d22345c6fb1091ea Forward-Compatible: yes
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.