Delete unused onSignOut method Once upon a time Gerrit performed a sign-out by just deleting the cookie and updating the DOM to remove signed-in content. This is not true anymore, the entire page is refreshed to delete any data that is private to a signed-in account, and to ensure the server can clear the correct HttpOnly cookies to actually do a sign-out. Since that behavior change, this onSignOut method is dead code. Change-Id: I7d7922f3a38fdcd03615866d0d693088660e1a31
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java index 8d5e105..b054175 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java
@@ -118,14 +118,6 @@ } @Override - public void onSignOut() { - super.onSignOut(); - if (starChange != null) { - starChange.setVisible(false); - } - } - - @Override protected void onLoad() { super.onLoad(); detailCache.refresh();
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/Screen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/Screen.java index 5cb4727..7f5eead 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/Screen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/Screen.java
@@ -15,8 +15,6 @@ package com.google.gerrit.client.ui; import com.google.gerrit.client.Gerrit; -import com.google.gerrit.common.PageLinks; -import com.google.gwt.user.client.History; import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.Grid; import com.google.gwt.user.client.ui.HasHorizontalAlignment; @@ -148,13 +146,6 @@ return requiresSignIn; } - /** Invoked if this screen is the current screen and the user signs out. */ - public void onSignOut() { - if (isRequiresSignIn()) { - History.newItem(PageLinks.toChangeQuery("status:open")); - } - } - public void onShowView() { if (windowTitle != null) { Gerrit.setWindowTitle(this, windowTitle);