commit | da60637959d833df6578d7a5d945e3371ae74a03 | [log] [tgz] |
---|---|---|
author | David Pursehouse <dpursehouse@collab.net> | Thu Nov 28 08:45:29 2019 +0900 |
committer | David Pursehouse <dpursehouse@collab.net> | Thu Nov 28 08:54:53 2019 +0900 |
tree | f3e4a5ef2f0eff0aab20fcdb626193c2d820dc0e | |
parent | 4fe28a47e8ff1f14c0a502bf50fe783754f2ce30 [diff] |
AccountsOnInit#getPath: Fix NPE in call to checkState The checkState is asserting that file is not null after being resolved, but then in the case where it *is* null, attempts to dereference it to build the error message, which will result in NPE without the expected message. Fix it so that it doesn't dereference the null file, but uses the path that was previously used in the resolve attempt. At the same time, replace usage of checkState and checkArgument with requireNonNull. The former methods are not recognized as null checks by some static checkers, SpotBugs for example, and thus result in false positive warnings about null dereferences. This also means there is a slight behavioral change: NullPointerException is raised rather than IllegalStateException. Change-Id: If66d32afb1d46ec451a2634c8eac82b46e4d5b8f
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.