Google Git
Sign in
gerrit / gerrit / d9c7684fcb2ddb880b497705b20755e186f7e180
commitd9c7684fcb2ddb880b497705b20755e186f7e180[log] [tgz]
authorDave Borowitz <dborowitz@google.com>Thu Aug 03 15:20:43 2017 -0400
committerDave Borowitz <dborowitz@google.com>Tue Aug 08 10:50:07 2017 -0400
treec1b011e6eb308abd83755f342ccb4a89d682f823
parent886d28d2ee8b64c60a4c4091cf0f1008bfc98b5e [diff]
Move ReceivePack creation into AsyncReceiveCommits

The general idea of the AsyncReceiveCommits->ReceiveCommits delegation
is that ReceiveCommits does all its work in a background thread whose
lifecycle is managed by AsyncReceiveCommits. Doing significant work in
the ReceiveCommits constructor to build a ReceivePack doesn't really fit
with that, especially considering that AsyncReceiveCommits then
immediately pulls the ReceivePack out of the ReceiveCommits and holds a
reference to it.

There was previously a reason that ReceiveCommits wanted to directly
manipulate the ReceivePack setters, which was to populate the allRefs
field. This logic has now been moved out to AllRefsWatcher, so at this
point there was no remaining reference from the ReceivePack to the
containing ReceiveCommits. It is now easy to move ReceivePack
construction into AsyncReceiveCommits.

This will make it possible (albeit still nontrivial) to make the entire
ReceiveCommits operation retryable.

Change-Id: I41bc8221bac01a0a88fc188b7a7fc3367a3f0267
2 files changed
tree: c1b011e6eb308abd83755f342ccb4a89d682f823
  1. .settings/
  2. contrib/
  3. Documentation/
  4. gerrit-acceptance-framework/
  5. gerrit-acceptance-tests/
  6. gerrit-antlr/
  7. gerrit-cache-h2/
  8. gerrit-common/
  9. gerrit-elasticsearch/
  10. gerrit-extension-api/
  11. gerrit-gpg/
  12. gerrit-gwtdebug/
  13. gerrit-gwtexpui/
  14. gerrit-gwtui/
  15. gerrit-gwtui-common/
  16. gerrit-httpd/
  17. gerrit-launcher/
  18. gerrit-lucene/
  19. gerrit-main/
  20. gerrit-oauth/
  21. gerrit-openid/
  22. gerrit-patch-commonsnet/
  23. gerrit-patch-jgit/
  24. gerrit-pgm/
  25. gerrit-plugin-api/
  26. gerrit-plugin-gwtui/
  27. gerrit-prettify/
  28. gerrit-reviewdb/
  29. gerrit-server/
  30. gerrit-sshd/
  31. gerrit-test-util/
  32. gerrit-util-cli/
  33. gerrit-util-http/
  34. gerrit-util-ssl/
  35. gerrit-war/
  36. lib/
  37. plugins/
  38. polygerrit-ui/
  39. ReleaseNotes/
  40. tools/
  41. website/
  42. .bazelproject
  43. .editorconfig
  44. .git-blame-ignore-revs
  45. .gitignore
  46. .gitmodules
  47. .mailmap
  48. .pydevproject
  49. BUILD
  50. COPYING
  51. INSTALL
  52. README.md
  53. SUBMITTING_PATCHES
  54. version.bzl
  55. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.