Buck: Remove usage of genfile()
genfile() is considered to be deprecated and is going to be discontinued
in future Buck releases [1].
[1] https://groups.google.com/forum/#!topic/buck-build/Ci8Y95USD8I
Change-Id: I7a5a1ee99d1448c412bb51b793c1e874dd3c62f4
diff --git a/tools/build.defs b/tools/build.defs
index 9ce28f2..305a22d 100644
--- a/tools/build.defs
+++ b/tools/build.defs
@@ -14,12 +14,8 @@
# These definitions support building a runnable version of Gerrit.
-DOCS_SRC = genfile('Documentation/html.zip')
+DOCS_HTML = '//Documentation:html'
DOCS_LIB = '//Documentation:index_lib'
-DOCS_DEP = [
- '//Documentation:html',
- '//Documentation:index_lib',
-]
LIBS = [
'//gerrit-war:log4j-config',
'//gerrit-war:init',
@@ -50,23 +46,20 @@
for l in pgmlibs:
cmd.extend(['--pgmlib', l])
- src = []
dep = []
if docs:
- src.append(DOCS_SRC)
- dep.extend(DOCS_DEP)
+ cmd.append('$(location %s)' % DOCS_HTML)
+ dep.append(DOCS_HTML)
+ dep.append(DOCS_LIB)
cmd.extend(['--lib', DOCS_LIB])
if context:
for t in context:
dep.append(t)
cmd.append('$(location %s)' % t)
- if src:
- cmd.append('$SRCS')
genrule(
name = name,
cmd = ' '.join(cmd),
- srcs = src,
deps = libs + pgmlibs + dep + ['//tools:pack_war'],
out = name + '.war',
visibility = visibility,
