| commit | d7e46c250408de7598bae755c3a0c75a4e9468d8 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Mon Dec 27 17:09:33 2021 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Tue Dec 28 14:31:18 2021 +0100 |
| tree | 632cd16849ebd292c695e35e543504f30af2aafe | |
| parent | 7c9dab387593143786360b4268795703285c45c4 [diff] |
Fix JdkObsolete issues with Date (part 2) This is a step towards enabling the error level for the JdkObsolete error prone check. Use Instant instead of Date/Timestamp. For usages of Date/Timestamp in the extension API suppress the warnings, since fixing this would break the API. Later we may consider breaking the Java extension API to get this fixed and use Gson adapters to maintain compatibility in the REST API. Since there are many usages of Date, and fixing all issues requires touching a lot of code, fixing the JdkObsolete issues with Date is done in steps over multiple changes. In this step we change the type for: * PatchsetApproval#granted * ChangeNotesParser#createdOn, ChangeNotesParser#lastUpdated and ChangeNotesParser#mergedOn * the date column in ReviewerSet and ReviewerByEmailSet * the date in ReviewerStatusUpdate and AssigneeStatusUpdate This includes modifying serializeable classes but this is fine since dates/timestamps are serialized as epoch millis and we can simply convert Instants to epoch millis too, and vice versa. Bug: Issue 15070 Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I9be945f297254bb6f80a3247c9b902682b74200e
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.