| commit | d7e04e6a6f0f4cd803d1f03a6ac5a80786533c4b | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Fri Dec 10 10:22:02 2021 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Fri Dec 10 10:31:49 2021 +0100 |
| tree | 8f41b40dfc98a338aa97f04ccf7dfd994438b971 | |
| parent | 10f3b8a3a57d58266d91e26b1aa750095e2eb345 [diff] |
Enable error level for the UndefinedEquals bug pattern in ErrorProne
Fix the current issues so that the build continues to work.
There were only 2 issues in thr prd code:
1. EmailHeader:
* [UndefinedEquals] Date does not have well-defined equals behavior.
* Instead of comparing Date objects, compare Date#getTime()
2. ChangeMessageInfo:
* The recommendation is to replace the Collection type with List, Set
or MultiSet.
* Since ChangeMessageInfo is part of the extensions which is the
plugin API that we promise to be stable we prefer not to change the
type here.
* Use Iterables.elementsEqual to do the comparison. Unfortunately
this method cannot handle null values, so we must handle them on
our own.
The rest of the issues were in test code and have been fixed in the way
that was most easy and straight-forward.
Bug: Issue 15080
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I618287c81dc0e0eedf8a14764fa520c595adc7f8
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.