commit d782a4f896e2c787c97f9819bfdf6f7b02479971
author Edwin Kempin <ekempin@google.com> Wed Jun 28 08:22:31 2017 +0200
committer Edwin Kempin <ekempin@google.com> Wed Jun 28 08:28:16 2017 +0200
tree 644c664ed425da8e0e38c3ff5625a10ff079e9e1
parent 79afe49b3058c7a0e7b3e02a909eda34663edee8

SearchSuggestOracle: Suggest "self" before other users

For query operators that expect a user, matching users are suggested.
The suggestion includes "self" if "self" matches what the user has
typed. Since "self" is used more frequently to complete queries than
actual user names it should appear first in the suggestion list.
Otherwise if "owner:sel" is typed and there are many user names starting
with "sel" selecting "self" from the suggestion list gets annoying as
one always needs to go to the end of the suggestion list.

Change-Id: I49253b7219d6776c997fbb49047d870f48b8bf89
Signed-off-by: Edwin Kempin <ekempin@google.com>

gerrit-gwtui/src/main/java/com/google/gerrit/client/SearchSuggestOracle.java

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/SearchSuggestOracle.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/SearchSuggestOracle.java
index 7a1a450..753d421 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/SearchSuggestOracle.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/SearchSuggestOracle.java
@@ -53,7 +53,6 @@
                           if ("self".startsWith(request.getQuery())) {
                             final ArrayList<SuggestOracle.Suggestion> r =
                                 new ArrayList<>(response.getSuggestions().size() + 1);
-                            r.addAll(response.getSuggestions());
                             r.add(
                                 new SuggestOracle.Suggestion() {
                                   @Override
@@ -66,6 +65,7 @@
                                     return "self";
                                   }
                                 });
+                            r.addAll(response.getSuggestions());
                             response.setSuggestions(r);
                           }
                           done.onSuggestionsReady(request, response);