Enable error level for the EmptyCatch bug pattern in ErrorProne

Fix the current issues so that the build continues to work.

Bug: Issue 15061
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ie782438764679e7736d1dff6a9e966cf9c478b03

java/com/google/gerrit/server/git/validators/CommitValidators.java

diff --git a/java/com/google/gerrit/server/git/validators/CommitValidators.java b/java/com/google/gerrit/server/git/validators/CommitValidators.java
index 056407e..1c7149a 100644
--- a/java/com/google/gerrit/server/git/validators/CommitValidators.java
+++ b/java/com/google/gerrit/server/git/validators/CommitValidators.java
@@ -969,6 +969,9 @@
       try {
         return new URL(canonicalWebUrl).getHost();
       } catch (MalformedURLException ignored) {
+        logger.atWarning().log(
+            "configured canonical web URL is invalid, using system default: %s",
+            ignored.getMessage());
       }
     }
 

plugins/replication

diff --git a/plugins/replication b/plugins/replication
index 756d349..af3dee4 160000
--- a/plugins/replication
+++ b/plugins/replication
@@ -1 +1 @@
-Subproject commit 756d349cb3a16652568aad46b34f2eb9c3d04a36
+Subproject commit af3dee4dc18c47a60ab7a97333e87c98b8379173

tools/BUILD

diff --git a/tools/BUILD b/tools/BUILD
index 3fd2a0f..2726132 100644
--- a/tools/BUILD
+++ b/tools/BUILD
@@ -168,7 +168,7 @@
         "-Xep:DurationTemporalUnit:ERROR",
         "-Xep:DurationToLongTimeUnit:ERROR",
         "-Xep:EmptyBlockTag:ERROR",
-        # "-Xep:EmptyCatch:WARN",
+        "-Xep:EmptyCatch:ERROR",
         "-Xep:EmptySetMultibindingContributions:ERROR",
         # "-Xep:EqualsGetClass:WARN",
         "-Xep:EqualsHashCode:ERROR",