| commit | d67706130f49e9111c90e6d637ea607d8ff29093 | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Fri May 13 11:03:51 2022 +0200 |
| committer | Ben Rohlfs <brohlfs@google.com> | Fri May 13 11:48:56 2022 +0200 |
| tree | 854fe48650262084d74e9113ecf799133bb80346 | |
| parent | 4404e2fc5aff216e4113d9a9ff9177005b5c2ffd [diff] |
Fix adding event listeners in change-view only once The change view had a bug where it would add event listeners to itself every time `connectedCallback()` was called. So these listeners were accumulating and handlers were called multiple times, if the component was disconnected from the DOM and the re-connected. Before migrating gr-app-element to Lit in change 336243 this bug was not exposed, because Polymer was just hiding the component, not disconnecting it. So there was just no scenario where a change view would be disconnected and then reconnected again. In Lit the view caching is handled differently, so we are now seeing issues due to the bug, e.g. events for saving the commit message being handled twice. The change view is disconnected and then reconnected every time that you go from a change view to a diff view (or any other view actually) and then back. Release-Notes: skip Google-Bug-Id: b/232499174 Change-Id: I5c57d29b36816f667160fe3118efeae5a8627c7b
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.