Merge "Revert "Hide automated messages by default""
diff --git a/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list.html b/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list.html
index d56e043..df9ce54 100644
--- a/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list.html
+++ b/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list.html
@@ -72,7 +72,7 @@
hidden$="[[!_hasAutomatedMessages(messages)]]">
<paper-toggle-button
id="automatedMessageToggle"
- checked="{{!_hideAutomated}}"></paper-toggle-button>All activity
+ checked="{{_hideAutomated}}"></paper-toggle-button>Only comments
<span class="transparent separator"></span>
</span>
<gr-button
diff --git a/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list.js b/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list.js
index 5076cfe..9ccadf7 100644
--- a/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list.js
+++ b/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list.js
@@ -49,7 +49,7 @@
},
_hideAutomated: {
type: Boolean,
- value: true,
+ value: false,
},
/**
* The messages after processing and including merged reviewer updates.
diff --git a/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list_test.html b/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list_test.html
index a491fd9..453d97a 100644
--- a/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list_test.html
+++ b/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list_test.html
@@ -199,12 +199,13 @@
.concat(_.times(11, randomMessage));
flushAsynchronousOperations();
- assert.isTrue(element.$.messageControlsContainer.hasAttribute('hidden'));
- MockInteractions.tap(element.$.automatedMessageToggle);
- flushAsynchronousOperations();
assert.equal(element.$.oldMessagesBtn.innerText.toUpperCase(),
'SHOW 1 MESSAGE');
assert.isFalse(element.$.messageControlsContainer.hasAttribute('hidden'));
+ MockInteractions.tap(element.$.automatedMessageToggle);
+ flushAsynchronousOperations();
+
+ assert.isTrue(element.$.messageControlsContainer.hasAttribute('hidden'));
});
test('message count still respects non-automated on toggle', () => {
@@ -476,23 +477,24 @@
assert.isNotOk(element.$$('#automatedMessageToggle[hidden]'));
});
- test('autogenerated messages are hidden initially', () => {
+ test('autogenerated messages are not hidden initially', () => {
const allHiddenMessageEls = getHiddenMessages();
// There are no hidden messages.
- assert.isTrue(!!allHiddenMessageEls.length);
+ assert.isFalse(!!allHiddenMessageEls.length);
});
- test('autogenerated messages displayed after comments only toggle', () => {
+ test('autogenerated messages hidden after comments only toggle', () => {
let allHiddenMessageEls = getHiddenMessages();
+
+ element._hideAutomated = false;
MockInteractions.tap(element.$.automatedMessageToggle);
flushAsynchronousOperations();
allMessageEls = getMessages();
allHiddenMessageEls = getHiddenMessages();
// Autogenerated messages are now hidden.
- assert.notEqual(allHiddenMessageEls.length, allMessageEls.length);
- assert.isFalse(!!allHiddenMessageEls.length);
+ assert.equal(allHiddenMessageEls.length, allMessageEls.length);
});
test('autogenerated messages not hidden after comments only toggle',
