ChangeJson: Add option to include review footers
We have a user who likes the feature of the cherry-pick submit type
but doesn't want to deal with the hassle of changes possibly going
into the SUBMITTED state. They plan to convert their automation to
push directly to branches, bypassing the submit handler entirely.
However, they still want to have review information in footers. Rather
than having them reimplement this piece of Gerrit logic on the client
side, add an option to include review footer info in change detail.
This is inherently racy, since reviews can happen between the most
recent fetch and the push to the branch with the new commit message,
but such races already exist in the submit codepath, as submit rules
are not evaluated in the same transaction as the merge attempt.
Change-Id: If95c6a1e1625fe5eff3300a3e9220643b92d08a2
7 files changed