commit d5e2ab9c560b30fe36d103fb962a9e25183776fe
author Edwin Kempin <ekempin@google.com> Wed Mar 23 09:18:57 2022 +0100
committer Edwin Kempin <ekempin@google.com> Wed Mar 23 09:21:19 2022 +0100
tree b9c23a01ae138b0c6e589d7365d1b16f5a872c9b
parent 82921901fcad608b3492dbc21027eefebc038066

StickyApprovalsIT: Assert test assumption that user cannot see the group

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I5be35f743ebe5e121dcb066854f0fcb9576c2331
Release-Notes: skip

javatests/com/google/gerrit/acceptance/api/change/StickyApprovalsIT.java

diff --git a/javatests/com/google/gerrit/acceptance/api/change/StickyApprovalsIT.java b/javatests/com/google/gerrit/acceptance/api/change/StickyApprovalsIT.java
index 546102a..3fd0405 100644
--- a/javatests/com/google/gerrit/acceptance/api/change/StickyApprovalsIT.java
+++ b/javatests/com/google/gerrit/acceptance/api/change/StickyApprovalsIT.java
@@ -29,6 +29,7 @@
 import static com.google.gerrit.server.group.SystemGroupBackend.REGISTERED_USERS;
 import static com.google.gerrit.server.project.testing.TestLabels.labelBuilder;
 import static com.google.gerrit.server.project.testing.TestLabels.value;
+import static com.google.gerrit.testing.GerritJUnit.assertThrows;
 import static java.util.Comparator.comparing;
 
 import com.google.common.cache.Cache;
@@ -62,6 +63,7 @@
 import com.google.gerrit.extensions.common.ApprovalInfo;
 import com.google.gerrit.extensions.common.ChangeInfo;
 import com.google.gerrit.extensions.common.FileInfo;
+import com.google.gerrit.extensions.restapi.ResourceNotFoundException;
 import com.google.gerrit.server.change.ChangeKindCacheImpl;
 import com.google.gerrit.server.project.testing.TestLabels;
 import com.google.gerrit.server.query.change.ChangeData;
@@ -725,8 +727,16 @@
 
   @Test
   public void stickyEvenWhenUserCantSeeUploaderInGroup() throws Exception {
-    // user can't see admin group
     String administratorsUUID = gApi.groups().query("name:Administrators").get().get(0).id;
+
+    // verify that user can't see the admin group
+    requestScopeOperations.setApiUser(user.id());
+    ResourceNotFoundException notFound =
+        assertThrows(
+            ResourceNotFoundException.class, () -> gApi.groups().id(administratorsUUID).get());
+    assertThat(notFound).hasMessageThat().isEqualTo("Not found: " + administratorsUUID);
+
+    requestScopeOperations.setApiUser(admin.id());
     updateCodeReviewLabel(b -> b.setCopyCondition("approverin:" + administratorsUUID));
 
     String changeId = createChange().getChangeId();