Google Git
Sign in
gerrit / gerrit / d57bc06871a0e4f622e4ff098cd9c6b592026a12
commitd57bc06871a0e4f622e4ff098cd9c6b592026a12[log] [tgz]
authorYoussef Elghareeb <ghareeb@google.com>Tue Oct 11 13:41:37 2022 +0200
committerYoussef Elghareeb <ghareeb@google.com>Tue Oct 11 15:23:19 2022 +0200
treebf2789baa0c28860672dfaca4c5c47c31b4bee15
parentfbd820689f049f6e5eeac1ee25ce7da2606f8961 [diff]
Reject uploading project config changes if they contain duplicate SRs

This is to prevent project owners and admins from accidentally adding
multiple definitions for the same submit requirement name. The current
behaviour is that one of the definitions override the other, but it's
better to reject such changes.

Existing setups that contain duplicate submit requirement definitions
will continue to work just fine. This is because the config parsing
errors are only checked on the upload config change path, but not during
the server's parsing of configs (e.g. after a server restart). A test is
added for this case.

Google-Bug-Id: b/240133667
Release-Notes: Reject uploading project config changes if they contain duplicate submit requirement definitions
Change-Id: Ib554f921a6683fc688b70dc0186f9b3ec509314a
2 files changed
tree: bf2789baa0c28860672dfaca4c5c47c31b4bee15
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.