Google Git
Sign in
gerrit / gerrit / d5403dbf335ba7d48977fc95170c3f7027c34659
commitd5403dbf335ba7d48977fc95170c3f7027c34659[log] [tgz]
authorOrgad Shaneh <orgad.shaneh@audiocodes.com>Sun Nov 26 12:33:12 2023 +0200
committerOrgad Shaneh <orgad.shaneh@audiocodes.com>Wed Nov 29 16:45:03 2023 +0000
tree1825ea26bce39b474c4e64d45106d1f27e220f26
parent01bd4b39d7ff47af9a73fd7c6cb5264cbd5f0f94 [diff]
commit-msg: Ignore all kinds of fixup/squash/amend temp commits

There are also "fixup!" and "amend!". During the review process of
https://gerrit-review.googlesource.com/c/gerrit/+/339555 fixup was
also ignored, but it was suggested to not ignore it, since it will
be eventually discarded anyway.

Executing the hook has a cost (especially for Windows, where shell
scripts are slow), and there is no reason to run the hook just for
discarding it shortly afterwards.

Moreover, *not* having Change-Id prevents accidental push of those
commits. It also enables the user to mark a commit that should not
be pushed by using a prefix such as "temp!".

Change the regex to ignore any word that is lowercase and followed
by an exclamation mark.

Add a new value to gerrit.createChangeId configuration that forces
Change-Id creation even for temp commits.

Amends commit 490149df4d93c0597429d4174dcdb71d6664c105.

Release-Notes: The commit-msg hook now operates as a no-op for temporary commits, which are identified by a lowercase word followed by an exclamation mark (e.g., fixup!, squash!). Configure gerrit.createChangeId to 'always' to force creation on these cases.
Change-Id: I8aa5384f23f5a119379950209083473e594d6e8d
3 files changed
tree: 1825ea26bce39b474c4e64d45106d1f27e220f26
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .pydevproject
  30. .zuul.yaml
  31. BUILD
  32. COPYING
  33. INSTALL
  34. Jenkinsfile
  35. MODULE.bazel
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.