Google Git
Sign in
gerrit / gerrit / e16a9c3b83a9dcff63f2ef94b63374df4dd32a96
commite16a9c3b83a9dcff63f2ef94b63374df4dd32a96[log] [tgz]
authorBen Rohlfs <brohlfs@google.com>Thu Apr 20 18:42:34 2023 +0200
committerBen Rohlfs <brohlfs@google.com>Mon Apr 24 09:43:52 2023 +0200
tree4bb0626d788327b37bf86fb87d8cacc76b0b2768
parent14a7b596da1d519d539d524b4f7d6104e74cab72 [diff]
Move ending of CHANGE_DISPLAYED and CHANGE_FULLY_LOADED timers

We want to further wipe the `viewStateChanged()` path. These timers
should have their own triggers. AFAICT we can call them as often as we
like, because the timer is only started on page navigation from the
router.

Triggering in `updated()` and then waiting for components to `render()`
seems to be the most useful and reliable thing to do for measuring
these user focused metrics.

CHANGE_DISPLAYED might see an increase in latency, because we are not
just waiting for the change to load, but also for the metadata component
to render. But I think that is more aligned with what we wanted to
achieve with that metric.

Release-Notes: skip
Change-Id: I3ff1e735ddff8084d6886dbbc98e4e294399ff4e
2 files changed
tree: 4bb0626d788327b37bf86fb87d8cacc76b0b2768
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.