| commit | d450a9eb57f6b2fdd0b28d79b9e99a32ce65b816 | [log] [tgz] |
|---|---|---|
| author | Becky Siegel <beckysiegel@google.com> | Fri Jan 26 13:49:01 2018 -0800 |
| committer | Becky Siegel <beckysiegel@google.com> | Sat Jan 27 00:29:32 2018 +0000 |
| tree | 9c1cffcc2d520c47ba25d99b5f31b76b9f34a884 | |
| parent | d2c2344b5c63e4d249200cf8febae4bea62cf2cb [diff] |
Respect default font size preference from browsers We encountered an issue where PolyGerrit was not respecting browser font preferences. Browser font preferences include both a default font size and a minimum font size. In the event that a font declared in px is smaller than the minimum font size, the size is increased to equal the minimum font size. However, if the font is declared in px and greater than the minimum, the preferred font size is not taken into account. Browsers' default font size is 16px [1], So instead of declaring the base font in px (previously 13px), this change makes it a percentage of the default font size. If the user has changed their default, this is taken into account. From this point, all other fonts will be declared in rems, which makes it easier to base the new size off of the base font size of the <html> tag, rather than ems which bases it on the container[2]. This allows us to declare font sizes in a way more similar to pixels, yet relative. A follow-up change will change all font size declaration to use rem from em for consistency. [1] https://stackoverflow.com/questions/29511983/is-the-default-font-size-of-every-browser-16px-why [2] https://webdesign.tutsplus.com/tutorials/comprehensive-guide-when-to-use-em-vs-rem--cms-23984 Bug: Issue 8157 Change-Id: I04ec2c861b2fb288ec7556dfb655d7feea9c9157
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.