| commit | 9f46d2e248fc588888dc0f562463185c843e6241 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Fri Feb 08 15:01:44 2019 -0800 |
| committer | Edwin Kempin <ekempin@google.com> | Mon Feb 11 15:11:42 2019 +0100 |
| tree | 6d3ca96f44b9fdf177a9adbe06a0f60d01695a12 | |
| parent | 4a4ab7b1a8af3616b85eb6ecbff08725bf1b0a27 [diff] |
Resolve "self" even if inactive Different systems may implement reactivation of accounts in different ways. On googlesource.com, for example, accounts are automatically reactivated on login through the web UI, but there are other codepaths where reactivation may not happen automatically. Filtering out inactive users when resolving "self" is therefore a regression: it would return no results where prior to the AccountResolver rewrite it would have returned results. Fix the regression by resolving "self" even when inactive. I'm not arguing that not auto-reactivating is the best behavior for googlesource.com, just switching back to the old behavior of AccountResolver. The regressed behavior was especially confusing to debug because it resulted in an exception message saying "Resolving account 'self' requires login", even though the user was technically logged in. Change-Id: I5aaf20eeb94ea6de268a96230d14ac85c4eb1863
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.