| commit | d28408229a47aef761de668e515b7f2ab5aaaa6f | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Mon Feb 06 13:11:30 2023 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Mon Feb 06 13:51:38 2023 +0100 |
| tree | 4752c14764ccc76a8172c15107a7a2cb19d66c70 | |
| parent | 8cd62075d07a0d76d027a973307bf8a55eb34be4 [diff] |
Fix ownerin/uploaderin for internal groups that include external groups The ownerin/uploaderin are post filter predicates, except for internal groups where the query is rewritten as an OR-query of owner/uploader predicates for all the group members as a performance optimisation. The problem is that this optimization doesn't work for internal groups that contain external groups as sub groups. This is because we can't list members of external groups and hence the rewritten query doesn't have predicates for the members of the included external groups and hence changes for them are not matched. To fix this we skip the optimisation for internal groups that contain external groups as sub groups and instead use the post filter predicate, same as for external groups. Release-Notes: Fixed ownerin/uploaderin for internal groups that include external groups Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I5cee8556be2306b2d486185fded37a0fccdf05ed Bug: Google b/267526103
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.