commit | ed80360d7ec515c21db57d132b7388c7e3a31f1d | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Fri Jan 17 14:22:47 2020 +0100 |
committer | Edwin Kempin <ekempin@google.com> | Fri Jan 17 14:33:01 2020 +0100 |
tree | 68617d007d666cde71158db46339db9ce8633166 | |
parent | cc909473eadd7779dd53069abf28675b9b03d7a0 [diff] |
RestApiServlet: Do not count non-error-exceptions as ISE if response is already committed If an exception occurs we return '500 Internal Server Error' by default. However ExceptionHook implementations can decide to return a different response status, e.g. if an exception is caused by a client that disconnects, an exception hook could return '499 Client Closed Request', which is not an internal server error. If this happens, we increase the http/server/rest_api/error_count metric for the status code that was returned by the exception hook, however this only worked if the response was not committed yet. If the response was already committed we counted all exceptions as '500 Internal Server Error', although an exception would have returned a different response code. This is bad because it can eat up the SLO budget. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: If6fd0b543a3d385a2d354f8604202f1663b89242
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.