PolyGerrit: Remove redundant local variables
Change-Id: I6937c50124ca4c2e98480facd41ccdc3638df740
diff --git a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.js b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.js
index 8583b4f..d25ee76 100644
--- a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.js
+++ b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.js
@@ -210,11 +210,10 @@
// It is possible to have a label name that is not included in the
// 'labels' object. In this case, treat it like anything else.
if (!labels[labelName]) { return; }
- const label = {
+ return {
name: labelName,
values: this._computeLabelValues(labels[labelName].values),
};
- return label;
}
_computeLabelValues(values) {
diff --git a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js
index 48d1a79..2e0584e 100644
--- a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js
+++ b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js
@@ -1027,9 +1027,8 @@
_filesChanged() {
if (this._files && this._files.length > 0) {
flush();
- const files = Array.from(
+ this.$.fileCursor.stops = Array.from(
dom(this.root).querySelectorAll('.file-row'));
- this.$.fileCursor.stops = files;
this.$.fileCursor.setCursorAtIndex(this.selectedIndex, true);
}
}
diff --git a/polygerrit-ui/app/elements/diff/gr-apply-fix-dialog/gr-apply-fix-dialog.js b/polygerrit-ui/app/elements/diff/gr-apply-fix-dialog/gr-apply-fix-dialog.js
index b63b87a..16dee09 100644
--- a/polygerrit-ui/app/elements/diff/gr-apply-fix-dialog/gr-apply-fix-dialog.js
+++ b/polygerrit-ui/app/elements/diff/gr-apply-fix-dialog/gr-apply-fix-dialog.js
@@ -118,10 +118,9 @@
.getRobotCommentFixPreview(this.changeNum, this._patchNum, fixId)
.then(res => {
if (res != null) {
- const previews = Object.keys(res).map(key => {
+ this._currentPreviews = Object.keys(res).map(key => {
return {filepath: key, preview: res[key]};
});
- this._currentPreviews = previews;
}
})
.catch(err => {
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-cursor/gr-diff-cursor.js b/polygerrit-ui/app/elements/diff/gr-diff-cursor/gr-diff-cursor.js
index c61ebfe..acb8f0c 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-cursor/gr-diff-cursor.js
+++ b/polygerrit-ui/app/elements/diff/gr-diff-cursor/gr-diff-cursor.js
@@ -289,10 +289,9 @@
reInitCursor() {
if (!this.diffRow) {
// does not scroll during init unless requested
- const scrollingBehaviorForInit = this.initialLineNumber ?
+ this._scrollMode = this.initialLineNumber ?
ScrollMode.KEEP_VISIBLE :
ScrollMode.NEVER;
- this._scrollMode = scrollingBehaviorForInit;
if (this.initialLineNumber) {
this.moveToLineNumber(this.initialLineNumber, this.side);
this.initialLineNumber = null;
diff --git a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff_test.html b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff_test.html
index 74df283..7db4372 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff_test.html
+++ b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff_test.html
@@ -834,8 +834,7 @@
});
test('setting', () => {
- const mockBlame = [{id: 'commit id', ranges: [{start: 1, end: 2}]}];
- element.blame = mockBlame;
+ element.blame = [{id: 'commit id', ranges: [{start: 1, end: 2}]}];
assert.isTrue(element.classList.contains('showBlame'));
});
});
@@ -1004,8 +1003,7 @@
}
setupSampleDiff({content});
assertDiffTableWithContent();
- const diffCopy = Object.assign({}, element.diff);
- element.diff = diffCopy;
+ element.diff = Object.assign({}, element.diff);
// immediately cleaned up
assert.equal(element.$.diffTable.innerHTML, '');
element._renderDiffTable();
