commit | 96ccc2388a4c6038e3c49e52c6031fda959ecd15 | [log] [tgz] |
---|---|---|
author | Luca Milanesio <luca.milanesio@gmail.com> | Wed Jan 06 22:46:27 2021 +0000 |
committer | Luca Milanesio <luca.milanesio@gmail.com> | Mon Jan 11 14:08:05 2021 +0000 |
tree | 6fce2ba39e917644900118008036992a63b1668d | |
parent | d7748bd81f2bb86c7a445eda089bf8dac15e1aab [diff] |
Add shadow-selection-polyfill The selection on shadow-DOM is not implemented in Safari and the document.getSelection() fallback is not suitable for use. The GoogleChromeLabs provided a library to solve the problem: shadow-selection-polyfill. What the library does is to manage the selection change events and calculate and cache the results for the shadow root elements, creating a custom event '-shadow-selectionchange' once the selection has been completed. There is one gotcha that makes things slightly more complicated: what the library provides is a Range and not a Selection object. There are a couple of adjustments needed in gr-diff and gr-diff-highlight to use the range directly instead of getting it from the selection. NOTE: Even though the shadow-selection-polyfill could also manage Chrome and Firefox, keep the existing logic to avoid any possible regression, which is not desireable on a stable branch. On stable-3.1, because of the problems related to the inclusion of the dependency via Bower, shadow.js has been removed from its exports and used as pure JS file included in the gr-diff.html. This change needs would not be applied to stable-3.2 where, thanks to the npm package mangement, it would be consumed from the NPM registry directly. Bug: Issue 11811 Change-Id: I41c4e94343010972c8a9f0f1ba3a059ca7af5292
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.