| commit | d121f72b1dc9e06d9daea3eb3cb98c196c0a2a5a | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Wed Dec 02 17:12:08 2020 +0100 |
| committer | Ben Rohlfs <brohlfs@google.com> | Thu Dec 03 08:39:31 2020 +0100 |
| tree | fc1f1037be86bd6fdfa4cfa5831a69122f32486b | |
| parent | c871a96a9e983c76eba7088b39b85a978d72f591 [diff] |
Define a default errFn for REST API calls from plugins The REST API service was recently fixed to fire error events on the document instead of on itself. This is a change in behavior for plugins, because they were using a component instance that was detached from the DOM. We want to revert back to the behavior where plugins would typically not expect Gerrit to handle errors by showing error dialogs. So we are defining a default errFn at least for the known case of a Chrome plugin that would otherwise show a distracting dialog when no config was found. We are swapping the catch() and then() clauses in the rest-api-helper such that errFn can throw an error without the catch() clause catching it. errFn throwing an error is the only situation where the swap matters. We are planning a lot of further clean-ups and want to ultimately remove the errFn support. There are a lot of follow-up changes expected, but here we just want to fix Gerrit and bring it into a releasable state. Change-Id: I3f441a0a7587b791223c4ae89fe0547cb2ea090c
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.