commit d11a0aa70cf93dbeacc724d121bd9bd9d786e8fb
author Paladox none <thomasmulhall410@yahoo.com> Wed Jul 07 17:45:48 2021 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Jul 07 17:45:48 2021 +0000
tree 409301397b2e0ba22d298e516ecb855da7c69500
parent 4018e88f21f1c1cb678ef417dc60335d07438382
parent 622903a3f4955229cc27993b6d0353c40c8fe3a7

Merge "Fix edit url when saving"

polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.ts

diff --git a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.ts b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.ts
index 8172f41..ae635eb 100644
--- a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.ts
+++ b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.ts
@@ -227,16 +227,8 @@
   }
 
   _viewEditInChangeView() {
-    const patch = this._successfulSave
-      ? (EditPatchSetNum as PatchSetNum)
-      : this._patchNum;
-    if (this._change && patch)
-      GerritNav.navigateToChange(
-        this._change,
-        patch,
-        undefined,
-        patch !== EditPatchSetNum
-      );
+    if (this._change)
+      GerritNav.navigateToChange(this._change, undefined, undefined, true);
   }
 
   _getFileData(

polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.js

diff --git a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.js b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.js
index a29d45d..8ae9827 100644
--- a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.js
+++ b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.js
@@ -317,19 +317,14 @@
     element._showAlert('test message');
   });
 
-  test('_viewEditInChangeView respects _patchNum', () => {
+  test('_viewEditInChangeView', () => {
     element._change = {};
     navigateStub.restore();
     const navStub = sinon.stub(GerritNav, 'navigateToChange');
     element._patchNum = EditPatchSetNum;
     element._viewEditInChangeView();
-    assert.equal(navStub.lastCall.args[1], EditPatchSetNum);
-    element._patchNum = '1';
-    element._viewEditInChangeView();
-    assert.equal(navStub.lastCall.args[1], '1');
-    element._successfulSave = true;
-    element._viewEditInChangeView();
-    assert.equal(navStub.lastCall.args[1], EditPatchSetNum);
+    assert.equal(navStub.lastCall.args[1], undefined);
+    assert.equal(navStub.lastCall.args[3], true);
   });
 
   suite('keyboard shortcuts', () => {