Google Git
Sign in
gerrit / gerrit / cf912c3496184264008891c13850fdacdb94db12
commitcf912c3496184264008891c13850fdacdb94db12[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Wed Oct 09 10:20:27 2019 +0200
committerEdwin Kempin <ekempin@google.com>Wed Oct 09 10:25:18 2019 +0200
treeb60261ca2eff11ddc85111b3d771da2514516afe
parent4af3c8de600334c4eb9ae39358fd63e80d427d78 [diff]
ReceiveCommits: Add thread-safety requirement as JavaDoc to sendMessages method

AsyncReceiveCommits may call ReceiveCommits#sendMessages while
ReceiveCommits#processCommands is still running (if the execution of
processCommands takes too long and AsyncReceiveCommits gets a timeout).
This means that local variables that are accessed in this method must be
thread-safe (otherwise we may hit a ConcurrentModificationException if
we read a variable in this method that at the same time is updated by
the background thread that still executes processCommands).

Fixes for ConcurrentModificationExceptions have been made by change
I5816fec63 and change I8b6e5de2a. Documenting this as JavaDoc should
help us to avoid similar issues in future.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I93cf5dc347e85bfd1264d3268e397cc53d53679c
1 file changed
tree: b60261ca2eff11ddc85111b3d771da2514516afe
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. e2e-tests/
  6. java/
  7. javatests/
  8. lib/
  9. plugins/
  10. polygerrit-ui/
  11. prolog/
  12. prologtests/
  13. proto/
  14. resources/
  15. tools/
  16. webapp/
  17. .bazelproject
  18. .bazelrc
  19. .bazelversion
  20. .editorconfig
  21. .git-blame-ignore-revs
  22. .gitignore
  23. .gitmodules
  24. .gitreview
  25. .mailmap
  26. .pydevproject
  27. BUILD
  28. COPYING
  29. INSTALL
  30. package.json
  31. README.md
  32. SUBMITTING_PATCHES
  33. version.bzl
  34. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.