commit | 91b4c321cf17674daeb4e5881113d83e656780e9 | [log] [tgz] |
---|---|---|
author | Joerg Zieren <zieren@google.com> | Thu Jun 06 09:57:53 2019 +0200 |
committer | Joerg Zieren <zieren@google.com> | Fri Jun 14 12:40:40 2019 +0200 |
tree | 939b13c38fcbcbcb5264b4cfbbd0a218c8a99481 | |
parent | e24a7a4d2dc1acd0852ae43f92f7a4e3b1bcb6c3 [diff] |
Add extension point for plugins to validate comments before publishing This allows to prevent publication of comments that fail validation. This change includes only the validator interface. There are three ways to publish comments: A) On posting the review draft comments are read and, possibly together with new comments included in the PostReview request, published. B) Running "git push" when the "Publish comments on push" user option is enabled (code in ReceiveCommits). C) Via email (code in MailProcessor). Subsequent changes will add the actual validation calls. Before plugins can use this interface with a reasonable UX, the UI needs to handle the new error in PostReview. Until then the UI will show an error message that does not indicate the comment validation failure. Change-Id: Icd1a206dc6468a2e9b08cf3a39de9860bc879c4b
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.