commit | cea2f5c2dcae1506793d5c66883ecb54597f7407 | [log] [tgz] |
---|---|---|
author | Nasser Grainawi <nasser.grainawi@linaro.org> | Mon Nov 07 18:17:40 2022 -0600 |
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | Tue Nov 08 00:17:40 2022 +0000 |
tree | 6e73fb1982bbfa4d7dba6afd022c3b467711049c | |
parent | ca31f2c04f5e52b468d77884b2061ea0f3589841 [diff] |
Update git submodules * Update plugins/replication from branch 'stable-3.5' to 419845f085c8991a8f324165788b2e4721501edc - Fix URI double escaping There were two problems here that had to be solved at the same time: 1) Escaping for a URI path uses different rules than encoding for a URL form. URLEncoder is intended for forms, so switch to using Guava's UrlEscapers.urlPathSegmentEscaper(). 2) When we replace the ${name} token in the JGit URIish, we need to call uri.setRawPath() so that uri.path is set to the unescaped URI. Add tests showing the now fixed URI escaping in the context of ReplicationTaskStorage. Also refactor getURI() to make it more testable and add tests for the correct behavior. Change-Id: I9be55fafd78f546aecdeffebedd1d0d5e136022f Release-Notes: https remote URIs correctly escape project names Release-Notes: Stored tasks with (broken) double escaped URIs must be manually removed
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.