| commit | cd6a24067204ed3644351646cf145d3bf9550490 | [log] [tgz] |
|---|---|---|
| author | Matthias Sohn <matthias.sohn@gmail.com> | Mon Mar 11 13:32:14 2024 +0000 |
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | Mon Mar 11 13:32:14 2024 +0000 |
| tree | b09ec40fece7c2d997493060c2daa329c6be2041 | |
| parent | bdb41354e4b0c589240cc1a03d98f2c7ba871c17 [diff] |
Update git submodules
* Update plugins/replication from branch 'master'
to aac252809094b8e4d4e26d69dab75a23d2da1770
- Merge "Prevent ConcurrentModificationException for PushOne.refBatchesToPush"
- Prevent ConcurrentModificationException for PushOne.refBatchesToPush
The PushOne.refBatchesToPush was a plain HashSet but r/w access to it
wasn't synchronized. Under some circumstances, traversing a stream
created on refBatchesToPush threw ConcurrentModificationException [1]
which caused the thread to die. As a side effect of the thread-death,
the replication task would never reschedule itself but would remain in
the pending tasks and all follow-up replications to the same URI would
be consolidated into that pending task which would never run. Only a
restart of the replication plugin would resolve the issue.
[1]
ERROR com.google.gerrit.server.git.WorkQueue : WorkQueue thread ReplicateTo-some-uri-2 threw exception
java.util.ConcurrentModificationException
at java.base/java.util.HashMap$KeySpliterator.tryAdvance(HashMap.java:1730)
at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:129)
at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:527)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:513)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
at com.googlesource.gerrit.plugins.replication.PushOne.getLimitedRefs(PushOne.java:255)
at com.googlesource.gerrit.plugins.replication.PushOne.toString(PushOne.java:221)
at com.google.gerrit.server.git.WorkQueue$ProjectTask.toString(WorkQueue.java:760)
at java.base/java.lang.StringConcatHelper.stringOf(StringConcatHelper.java:453)
at com.google.gerrit.server.git.WorkQueue$Task.run(WorkQueue.java:678)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:840)
Change-Id: I3f29779fd150868412e4994d307303d1dd8bde7b
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.