Google Git
Sign in
gerrit / gerrit / 74a3945b982e96232d9ea82c7cb5239935183d56
commit74a3945b982e96232d9ea82c7cb5239935183d56[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Tue Jan 17 08:34:14 2023 +0100
committerEdwin Kempin <ekempin@google.com>Tue Jan 17 08:11:24 2023 +0000
treea56c3b7638ac2cf346378f4e0fc36284e3f81c8b
parent1983ac7a8cf43416c76de26bdffde97ae8a7ef34 [diff]
Reland "Fix error when using the message operator with regex on ..."

This relands change I99e2b8a3d that was reverted by change I4e551ac53.

The problem with the original change was that it no longer used the
checkFieldAvailable method to throw the QueryParseException. This method
is overridden in SubmitRequirementChangeQueryBuilder to suppress field
checks for operators that are used in submit requirement expressions.
Since submit requirement expressions are evaluated in memory the version
of the index and the available fields do not matter for them.

Fix this by changing the checkFieldAvailable method so that it supports
an arbitrary error message. This way we can also use it to throw the
QueryParseException with the improved error message. Checking for an
unsupported operator is done by the checkOperatorAvailable method now
that delegates to the checkFieldAvailable method. This way all
QueryParseExceptions are thrown from the checkFieldAvailable method and
overriding it in SubmitRequirementChangeQueryBuilder to suppress the
exceptions for submit requirement expressions works in all cases.

Change-Id: I6c73ecadfa0bfaaa70aaf7c2050fc1df555760f7
Bug: Google b/264478714
Release-Notes: skip
1 file changed
tree: a56c3b7638ac2cf346378f4e0fc36284e3f81c8b
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.