Google Git
Sign in
gerrit / gerrit / cc386031455272cc57b20174469353677e279d9c
commitcc386031455272cc57b20174469353677e279d9c[log] [tgz]
authorDarius Jokilehto <dariusjokilehto+os@gmail.com>Fri Apr 21 14:53:45 2023 +0100
committerDarius Jokilehto <dariusjokilehto+os@gmail.com>Fri Apr 28 13:51:58 2023 +0100
tree9a41558a844b95cc823177e9458ee07dfe8556b2
parent21ef86b703f2d353d000abf7e9cb34749c62fbc5 [diff]
Log external ID differential cache loader failure

We've investigated this issue and tried different ways of getting this
to fail, but haven't been successful.

We've investigated the algorithm, but haven't found any faults. We also
considered concurrency, but as we lock the cache before calling the
differential loader, we're not sure how that could be the issue.

We've managed to recreate the issue by fudging the input to the private
method, where we pass a key to `additions` that is already present in
the cache, but we don't see how that would be possible from the public
`load` entrypoint.

In order to continue the investigation we require more information, we
have opted to add some further logs when the differential cache loader
errors.

We now log the tip of the external ID cache as well as the external ID
ref on disk. We also log the set of additions, to confirm a key clash.

Bug: Issue 16384
Release-Notes: skip
Change-Id: I3836f28285b4fdcfd2e26720bdbf82cf046960c7
1 file changed
tree: 9a41558a844b95cc823177e9458ee07dfe8556b2
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.