Fix all hints discovered by the new linter
`npm run eslintfix`
Change-Id: Ic07aede1b95e7dd53bbd05c062e2afcef5508c10
diff --git a/polygerrit-ui/app/elements/diff/gr-comment-api/gr-comment-api.ts b/polygerrit-ui/app/elements/diff/gr-comment-api/gr-comment-api.ts
index 315fbfb..b99a17b 100644
--- a/polygerrit-ui/app/elements/diff/gr-comment-api/gr-comment-api.ts
+++ b/polygerrit-ui/app/elements/diff/gr-comment-api/gr-comment-api.ts
@@ -552,8 +552,9 @@
)
);
}
- const commentThreadCount = threads.filter(thread => !isDraftThread(thread))
- .length;
+ const commentThreadCount = threads.filter(
+ thread => !isDraftThread(thread)
+ ).length;
const unresolvedCount = threads.reduce((cnt, thread) => {
if (isUnresolved(thread)) cnt += 1;
return cnt;
@@ -627,10 +628,8 @@
this.restApiService.getPortedDrafts(changeNum, patchNum),
]).then(res => {
if (!this._changeComments) return;
- this._changeComments = this._changeComments.cloneWithUpdatedPortedComments(
- res[0],
- res[1]
- );
+ this._changeComments =
+ this._changeComments.cloneWithUpdatedPortedComments(res[0], res[1]);
});
}
}
diff --git a/polygerrit-ui/app/elements/diff/gr-context-controls/gr-context-controls.ts b/polygerrit-ui/app/elements/diff/gr-context-controls/gr-context-controls.ts
index 86a60ce..4b32f5e 100644
--- a/polygerrit-ui/app/elements/diff/gr-context-controls/gr-context-controls.ts
+++ b/polygerrit-ui/app/elements/diff/gr-context-controls/gr-context-controls.ts
@@ -515,11 +515,13 @@
private contextRange() {
return {
leftStart: this.contextGroups[0].lineRange.left.start_line,
- leftEnd: this.contextGroups[this.contextGroups.length - 1].lineRange.left
- .end_line,
+ leftEnd:
+ this.contextGroups[this.contextGroups.length - 1].lineRange.left
+ .end_line,
rightStart: this.contextGroups[0].lineRange.right.start_line,
- rightEnd: this.contextGroups[this.contextGroups.length - 1].lineRange
- .right.end_line,
+ rightEnd:
+ this.contextGroups[this.contextGroups.length - 1].lineRange.right
+ .end_line,
};
}
diff --git a/polygerrit-ui/app/elements/diff/gr-context-controls/gr-context-controls_test.ts b/polygerrit-ui/app/elements/diff/gr-context-controls/gr-context-controls_test.ts
index a1fc6d8..cacea42 100644
--- a/polygerrit-ui/app/elements/diff/gr-context-controls/gr-context-controls_test.ts
+++ b/polygerrit-ui/app/elements/diff/gr-context-controls/gr-context-controls_test.ts
@@ -32,7 +32,7 @@
setup(async () => {
element = document.createElement('gr-context-controls');
- element.diff = ({content: []} as any) as DiffInfo;
+ element.diff = {content: []} as any as DiffInfo;
element.renderPreferences = {};
element.section = document.createElement('div');
blankFixture.instantiate().appendChild(element);
@@ -124,9 +124,9 @@
function prepareForBlockExpansion(syntaxTree: SyntaxBlock[]) {
element.renderPreferences!.use_block_expansion = true;
- element.diff!.meta_b = ({
+ element.diff!.meta_b = {
syntax_tree: syntaxTree,
- } as any) as DiffFileMetaInfo;
+ } as any as DiffFileMetaInfo;
}
test('context control with block expansion at the top', async () => {
@@ -360,12 +360,10 @@
const blockExpansionButtons = element.shadowRoot!.querySelectorAll(
'.blockExpansion paper-button'
);
- const tooltipAbove = blockExpansionButtons[0].querySelector(
- 'paper-tooltip'
- )!;
- const tooltipBelow = blockExpansionButtons[1].querySelector(
- 'paper-tooltip'
- )!;
+ const tooltipAbove =
+ blockExpansionButtons[0].querySelector('paper-tooltip')!;
+ const tooltipBelow =
+ blockExpansionButtons[1].querySelector('paper-tooltip')!;
assert.equal(
tooltipAbove.querySelector('.breadcrumbTooltip')!.textContent?.trim(),
'20 common lines'
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-image.ts b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-image.ts
index 1243e8f..b42e90a 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-image.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-image.ts
@@ -96,8 +96,8 @@
imageViewer.baseUrl = this._getImageSrc(this._baseImage);
imageViewer.revisionUrl = this._getImageSrc(this._revisionImage);
- imageViewer.automaticBlink = !!this._renderPrefs?.image_diff_prefs
- ?.automatic_blink;
+ imageViewer.automaticBlink =
+ !!this._renderPrefs?.image_diff_prefs?.automatic_blink;
td.appendChild(imageViewer);
tr.appendChild(td);
@@ -222,8 +222,8 @@
'gr-image-viewer'
) as GrImageViewer;
if (this._useNewImageDiffUi && imageViewer) {
- imageViewer.automaticBlink = !!renderPrefs?.image_diff_prefs
- ?.automatic_blink;
+ imageViewer.automaticBlink =
+ !!renderPrefs?.image_diff_prefs?.automatic_blink;
}
}
}
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.ts b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.ts
index 864fd79..987f808 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.ts
@@ -760,11 +760,8 @@
_buildMoveControls(group: GrDiffGroup) {
const movedIn = group.adds.length > 0;
- const {
- numberOfCells,
- movedOutIndex,
- movedInIndex,
- } = this._getMoveControlsConfig();
+ const {numberOfCells, movedOutIndex, movedInIndex} =
+ this._getMoveControlsConfig();
let controlsClass;
let descriptionIndex;
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/token-highlight-layer.ts b/polygerrit-ui/app/elements/diff/gr-diff-builder/token-highlight-layer.ts
index 18696f2..8a87791 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-builder/token-highlight-layer.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/token-highlight-layer.ts
@@ -191,9 +191,7 @@
this.notifyForToken(newHighlight, newLineNumber ?? 0);
}
- findTokenAncestor(
- el?: EventTarget | Element | null
- ): {
+ findTokenAncestor(el?: EventTarget | Element | null): {
token?: string;
line: number;
} {
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-mode-selector/gr-diff-mode-selector.ts b/polygerrit-ui/app/elements/diff/gr-diff-mode-selector/gr-diff-mode-selector.ts
index 6fe9d27..4eb33c7 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-mode-selector/gr-diff-mode-selector.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-mode-selector/gr-diff-mode-selector.ts
@@ -51,7 +51,9 @@
/** @override */
connectedCallback() {
super.connectedCallback();
- ((IronA11yAnnouncer as unknown) as FixIronA11yAnnouncer).requestAvailability();
+ (
+ IronA11yAnnouncer as unknown as FixIronA11yAnnouncer
+ ).requestAvailability();
}
/**
diff --git a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.ts b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.ts
index 90ffa4d..61718ba 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.ts
@@ -884,9 +884,9 @@
);
this._setLoading(false);
this._unobserveIncrementalNodes();
- this._incrementalNodeObserver = (dom(
- this
- ) as PolymerDomWrapper).observeNodes(info => {
+ this._incrementalNodeObserver = (
+ dom(this) as PolymerDomWrapper
+ ).observeNodes(info => {
const addedThreadEls = info.addedNodes.filter(isThreadEl);
// Removed nodes do not need to be handled because all this code does is
// adding a slot for the added thread elements, and the extra slots do
