Google Git
Sign in
gerrit / gerrit / ca3d495c7d660dfb722b4f567bc2bfba25188aff
commitca3d495c7d660dfb722b4f567bc2bfba25188aff[log] [tgz]
authorDhruv Srivastava <dhruvsri@google.com>Mon Aug 08 20:58:04 2022 +0200
committerDhruv Srivastava <dhruvsri@google.com>Tue Aug 09 09:23:37 2022 +0200
treeee69fa2c4d135e70063902b94e8354fc1d441b85
parent62fc516a1bc96c92cda44c5a4ce8d4956b66e753 [diff]
Ignore removal request from reviewer when removing an owner

Change 342254 relied on calculating the difference between
existing reviewers and the reviewers list in GrAccountList to
decide which users were removed.

However in some cases, the owner is returned as a reviewer in the
ChangeInfo object, and trying to remove the owner returns in a
500 server error.

Hence explicitly filter out removal of owner from the review input.

Verified on staging that the similar behaviour does not happen for
uploader. Ie if the uploader voted on the change before, they are
not returned as a reviewer.

Release-Notes: skip
Google-bug-id: b/236921879
Change-Id: I3fa6a5ce8ba7bf3e540701d695abbdcc8f3a9558
2 files changed
tree: ee69fa2c4d135e70063902b94e8354fc1d441b85
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.