c8f53ba914453552fa44b54df945f8ea6fd50069 - gerrit

commit	c8f53ba914453552fa44b54df945f8ea6fd50069	[log] [tgz]
author	Shawn Pearce <sop@google.com>	Sat Jul 20 16:08:08 2013 -0700
committer	Michael Zhou <moz@google.com>	Sun Jul 21 12:11:41 2013 -0700
tree	770ed6407b71eafdef70f8bf289a06260729c1fe
parent	4d71ba02370c9d2c4f572c98b805a4f46cf170f2 [diff]

SideBySide2: Hide CodeMirror when dialogs display

If ErrorDialog shows while CodeMirror is visible many of the
CodeMirror elements show above the dialog.  CM3 uses a number
of z-index values to display its content and some of them are
higher than the GWT dialogs.

Use a global handler registration system to hide CM3 widgets
when a dialog opens, similar to how flash movies are hidden.

Set the z-index of SearchPanel's popup and UserInfoPopup to 5
to make sure it's on top of all CodeMirror widgets.

Change-Id: Ied80d0ec8deeab574c9d661aabbbe26eeb70e74a

gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/DialogVisibleEvent.java[Added - diff]
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/DialogVisibleHandler.java[Added - diff]
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/PluginSafeDialogBox.java[diff]
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/PluginSafePopupPanel.java[diff]
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/user/client/UserAgent.java[diff]
gerrit-gwtui/src/main/java/com/google/gerrit/client/GerritCss.java[diff]
gerrit-gwtui/src/main/java/com/google/gerrit/client/SearchPanel.java[diff]
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySide2.java[diff]
gerrit-gwtui/src/main/java/com/google/gerrit/client/gerrit.css[diff]

9 files changed