Google Git
Sign in
gerrit / gerrit / c893c02b32a9be96eb5f5d2665fd273fa8853a26
commitc893c02b32a9be96eb5f5d2665fd273fa8853a26[log] [tgz]
authorDave Borowitz <dborowitz@google.com>Wed Dec 20 08:14:27 2017 -0500
committerDavid Pursehouse <dpursehouse@collab.net>Wed Nov 07 10:00:03 2018 +0900
treeec1bd3b054da23c6ac554e994df0ea500ee361bb
parent3c7f7e67b59caa4a1c858fb4d53a2cf94a1e8f15 [diff]
AbstractChangeNotes: Never open repo when NoteDb is off

This line has seen some action before in I1867f633, and before that in
I265ef862. Rereading those commit messages, I see no reason why we
should be opening the repo and possibly triggering auto-rebuilding when
NoteDb writes and reads are both disabled.

This was causing NoSuchChangeExceptions in the case where the Change
contained a noteDbState field but the ref was absent. That logic is also
questionable, for reasons now mentioned in a TODO. But really we should
never be reaching the openHandle method when NoteDb is completely off.

Add a regression test that would have caught this.

Change-Id: If0970e1cf61e1d98ccbb3ce27549186f5771466a
3 files changed
tree: ec1bd3b054da23c6ac554e994df0ea500ee361bb
  1. .settings/
  2. contrib/
  3. Documentation/
  4. gerrit-acceptance-framework/
  5. gerrit-acceptance-tests/
  6. gerrit-antlr/
  7. gerrit-cache-h2/
  8. gerrit-cache-mem/
  9. gerrit-common/
  10. gerrit-elasticsearch/
  11. gerrit-extension-api/
  12. gerrit-gpg/
  13. gerrit-gwtdebug/
  14. gerrit-gwtexpui/
  15. gerrit-gwtui/
  16. gerrit-gwtui-common/
  17. gerrit-httpd/
  18. gerrit-launcher/
  19. gerrit-lucene/
  20. gerrit-main/
  21. gerrit-oauth/
  22. gerrit-openid/
  23. gerrit-patch-commonsnet/
  24. gerrit-patch-jgit/
  25. gerrit-pgm/
  26. gerrit-plugin-api/
  27. gerrit-plugin-gwtui/
  28. gerrit-prettify/
  29. gerrit-reviewdb/
  30. gerrit-server/
  31. gerrit-sshd/
  32. gerrit-test-util/
  33. gerrit-util-cli/
  34. gerrit-util-http/
  35. gerrit-util-ssl/
  36. gerrit-war/
  37. lib/
  38. plugins/
  39. polygerrit-ui/
  40. ReleaseNotes/
  41. tools/
  42. website/
  43. .bazelproject
  44. .bazelrc
  45. .editorconfig
  46. .git-blame-ignore-revs
  47. .gitignore
  48. .gitmodules
  49. .mailmap
  50. .pydevproject
  51. 0001-Replace-native-http-git-_archive-with-Skylark-rules.patch
  52. BUILD
  53. COPYING
  54. INSTALL
  55. README.md
  56. SUBMITTING_PATCHES
  57. version.bzl
  58. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.