commit | c868c916ce2f6eb7597b51a11616bd0a640fd187 | [log] [tgz] |
---|---|---|
author | Youssef Elghareeb <ghareeb@google.com> | Tue Oct 12 09:22:47 2021 +0200 |
committer | Youssef Elghareeb <ghareeb@google.com> | Tue Oct 12 14:35:17 2021 +0200 |
tree | 926b54910d6c67f9b87fb791f608a738453a344d | |
parent | 716de601faaf7f6f015a2df3ca345abcfab8bb86 [diff] |
ListOfFilesUnchangedPredicate: Ignore due to rebase file modifications This predicate checks that the user modified the same set of files between two patchsets by inspecting the {base vs. prior PS} diff and checking if it has the exact same file paths and change types as the {base vs. current PS} diff. Sometimes these two diffs are not exact and the difference is in some file path that was modified due to rebase (i.e. a modification between the two parent commits of both patchsets). We are fixing this issue by checking that these difference files exist in the {prior PS vs. current PS} diff. For example if {base vs. current} contains a file that's not in {base vs. prior}, but {prior vs. current} does not have this file, then this file was modified due to rebase and the diff cache skipped this file in the {prior vs. current diff}, so we can also ignore this file. The added test fails before this fix and passes with it. Bug: Google b/202528151 Change-Id: I50f3509febe774fb29ac44a04da5c73cf9d303fa
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.