| commit | c7f07dca19e300e94f9f476eda91dccfbb1ec82e | [log] [tgz] |
|---|---|---|
| author | Becky Siegel <beckysiegel@google.com> | Thu Nov 02 16:07:13 2017 -0700 |
| committer | Becky Siegel <beckysiegel@google.com> | Mon Nov 06 14:31:59 2017 -0800 |
| tree | 27bcd76cb242d04fc59e9694fd833e78a9fcd35c | |
| parent | b9ed928073ba22caaae1ce1bd747fdb1afc5bc56 [diff] |
Update gr-comment-api Previously, nested components (that are never standalone) were making their own requests for comments, creating unecessary duplicate API requests. Some requests were made to the rest API directly (for example, gr-change-view requested comments this way), and some were through the gr-comment-api, which also helped handle comment manipulation and reorganization. Instead of ad-hoc comment requesting, move all comment requests to the top level (standalone) component, and use an object prototype to generate _changeComments as a property on gr-comment-api. This is an immutable object that can be passed to the inner components (file list, etc), and includes the methods needed to manipulate comments into the forms necessary. When a child component needs to trigger a refresh of the comments, fire an event that the parent event handles (see gr-file-list l.867). Bug: Issue 6953 Change-Id: Ic4b6cf16520baae65d8cf956c311a60f2a70a2e1
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.