| commit | 47a462d1aa39ffd562f606ffb42b87388a5a6c74 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Tue Sep 15 14:56:45 2015 -0400 |
| committer | Dave Borowitz <dborowitz@google.com> | Fri Oct 09 10:04:18 2015 -0400 |
| tree | a6b54d24890de5d23ff146bec5ed720b295962ac | |
| parent | e8589c8e5344116d4df704549ac1a62d7116b9ae [diff] |
Distinguish case where a public key must match a specific user GerritPublicKeyChecker was always checking that the user IDs in the key matched at least one identity from AccountExternalIds for the current user in the request. This was broken when combined with web-of-trust checks, since only the initial key passed to check() matches the current user; all other keys match different users. Add a factory to create two different kinds of checkers, depending on whether we have a specific user in mind that we want to match the initial key against. Expose the depth to checkCustom() so we only use this user on the initial call and not on later recursive calls. Add tests to GerritPublicKeyCheckerTest for web-of-trust checks, which were previously only in PublicKeyCheckerTest. Change-Id: I1af584354f26c80e9ed3b7643ed6e3624820214c
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build all
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.