commit c610ae1c2aba9d617bf873c7d8d2147089baf39a
author Paladox none <thomasmulhall410@yahoo.com> Sat Jul 27 20:41:35 2019 +0000
committer Paladox none <thomasmulhall410@yahoo.com> Mon Aug 26 22:50:41 2019 +0000
tree 154b54383f0d7bac818d4d3c57d8e11514d5bfff
parent b628b3a5a5e1a9f0b99f8402db25baa0847b8779

Fix gr-permission test under Polymer 2

Change-Id: I3a9d361bd239e734cf1353816a1144c4101d1610

polygerrit-ui/app/elements/admin/gr-permission/gr-permission_test.html

diff --git a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission_test.html b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission_test.html
index 8e57534..63f3eaf 100644
--- a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission_test.html
+++ b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission_test.html
@@ -329,8 +329,17 @@
           name: 'ldap/tests tests'}});
         assert.equal(element._rules.length, 3);
         assert.equal(Object.keys(element._groupsWithRules).length, 3);
-        assert.deepEqual(element.permission.value.rules['ldap:CN=test test'],
-            {action: 'ALLOW', min: -2, max: 2, added: true});
+        if (Polymer.Element) {
+          // Under Polymer 2 gr-rule-editor.js#_handleValueChange get's
+          // fully loaded before this change, thus `modified: true` get's managed
+          // to be added. Under Polymer 1 it was a mix hence why it was not
+          // added in time for when this test ran.
+          assert.deepEqual(element.permission.value.rules['ldap:CN=test test'],
+              {action: 'ALLOW', min: -2, max: 2, modified: true, added: true});
+        } else {
+          assert.deepEqual(element.permission.value.rules['ldap:CN=test test'],
+              {action: 'ALLOW', min: -2, max: 2, added: true});
+        }
         // New rule should be removed if cancel from editing.
         element.editing = false;
         assert.equal(element._rules.length, 2);