| commit | a47258be4ea1cb95505b68f373206fe483e92ff1 | [log] [tgz] |
|---|---|---|
| author | Han-Wen Nienhuys <hanwen@google.com> | Mon Dec 02 18:33:03 2019 +0100 |
| committer | David Pursehouse <dpursehouse@collab.net> | Tue Dec 03 08:33:36 2019 +0900 |
| tree | 5569559b53ce8a60a0ae324ef395d33560d40940 | |
| parent | 5e80fdc639a896f8451ed91856e058a6f4c8ae41 [diff] |
Fix deletion of draft comment refs In NoteDb, we store draft comments in the All-Users repository. This improves performance in the googlesource.com deployment, as high-traffic repositories can be configured to bypass Gerrit ACL checks for the ref advertisement. This makes publishing comments non-atomic: after publishing comments successfully, the update of the draft branch may fail. For this reason, any NoteDb update that touches the draft ref in All-Users will schedule a deletion of all published comments for the change. If there were multiple patchsets, scheduling deletions of items that were not in the draft ref triggered a logic error in ChangeDraftUpdate, which caused the branch to become empty rather than deleted. This had the following consequences: * unused draft refs persisted in the All-Users repository, polluting the namespace. * published draft comments as well as deleted draft comments were kept in the history of the draft ref, keeping them alive for GC, and causing a steady increase of repository size. In other words, for this to trigger, a change would have to publish draft comments on a change with multiple patchsets, and a previously published comment. The problem was not visible to users of Gerrit. This changes fixes the problem by simply looking at the notemap to be serialized, and deleting the draft ref if the new notemap is empty. Existing refs must still be cleaned up. We could introduce code, perhaps in the ProjectConsistencyChecker, to remove the stale refs from All-Users. Change-Id: I6f7b65828bb047bbff041b4d78f6b40190e76219
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.