commit c4ccc2db016071ccffd08b0ac40218d8fa8d891d
author Shawn Pearce <sop@google.com> Fri Aug 23 16:38:15 2013 -0700
committer Edwin Kempin <edwin.kempin@gmail.com> Tue Aug 27 05:15:44 2013 +0000
tree 22d5cb6cbf31969375394390375baf45a008e789
parent 2de365c05f4fa938b26b15e337ce7106dfe4ae3f

ChangeScreen2: Highlight the opened right side popdown panel

When a popdown panel is open draw its text in bold. This makes
it more obvious which panel is open when there are more than
one panels in this part of the UI.

Change-Id: Ibe9d5e6574f25bb60832aa73efe1fe5ac0cdc2d5

gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.java

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.java
index ddb2c7f..549a1b7 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.java
@@ -102,6 +102,7 @@
     String label_may();
     String label_need();
     String replyBox();
+    String selected();
   }
 
   private final Change.Id changeId;

gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.ui.xml

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.ui.xml b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.ui.xml
index ee0c74a..8e4b8f4 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.ui.xml
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.ui.xml
@@ -92,11 +92,11 @@
       cursor: pointer;
       height: 25px;
       border: none;
-      border-left: 1px solid #fff;
+      border-left: 2px solid #fff;
       background-color: trimColor;
-      margin-right: 0;
-      padding-left: 0;
-      padding-right: 0;
+      margin: 0;
+      padding-left: 2px;
+      padding-right: 2px;
     }
     .popdown button div {
       padding-left: 6px;
@@ -105,6 +105,9 @@
     .popdown button div:after {
       content: " \25bc";
     }
+    .popdown button.selected {
+      font-weight: bold;
+    }
 
     .headerTable {
       border-spacing: 0;

gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RightSidePopdownAction.java

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RightSidePopdownAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RightSidePopdownAction.java
index f73f418..3424064 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RightSidePopdownAction.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RightSidePopdownAction.java
@@ -44,6 +44,7 @@
 
   void show() {
     if (popup != null) {
+      button.removeStyleName(style.selected());
       popup.hide();
       return;
     }
@@ -68,6 +69,7 @@
       @Override
       public void onClose(CloseEvent<PopupPanel> event) {
         if (popup == p) {
+          button.removeStyleName(style.selected());
           popup = null;
         }
       }
@@ -75,6 +77,7 @@
     p.add(getWidget());
     p.showRelativeTo(relativeTo);
     GlobalKey.dialog(p);
+    button.addStyleName(style.selected());
     popup = p;
   }
 }