c4af33451e10e3e23c8ee317fe9e4bd03ccc412a - gerrit

commit	c4af33451e10e3e23c8ee317fe9e4bd03ccc412a	[log] [tgz]
author	Edwin Kempin <edwin.kempin@sap.com>	Wed Jun 29 14:34:33 2011 +0200
committer	Edwin Kempin <edwin.kempin@sap.com>	Tue Jul 05 14:09:30 2011 +0200
tree	4e3b510c380b145c9ee61b4958bfa9bffb2433fa
parent	a65637cccbc349e0d1aa072325aff16486202993 [diff]

Refactoring: Merge AddMemberBox and AddIncludedGroupBox

Merge AddMemberBox and AddIncludedGroupBox into one class since most
of the coding is identical.

This refactoring is a preparation for allowing groups being added as
reviewers for a change. Otherwise to implement this feature it would
be needed to introduce a third class AddAccountOrAccountGroupBox
which would again be almost identical in coding. The idea is to just
have one class which can be used for all three cases.

Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Change-Id: I667b6ba1ce8390c18e6ec2f1ef16d64f93926c01

gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccountGroupMembersScreen.java[diff]
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ApprovalTable.java[diff]
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.java[diff]
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties[diff]
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/AddIncludedGroupBox.java[Deleted - diff]
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/AddMemberBox.java[diff]

6 files changed