Google Git
Sign in
gerrit / gerrit / d505dccf5c438868ab0a1192d066a9500fb04ff3
commitd505dccf5c438868ab0a1192d066a9500fb04ff3[log] [tgz]
authorSaša Živkov <sasa.zivkov@sap.com>Thu May 28 17:50:58 2020 +0200
committerLuca Milanesio <luca.milanesio@gmail.com>Fri May 29 21:09:57 2020 +0000
tree82d7c2507e1951d749a0339940a960d27e81223b
parent2d9a44d5f50696746b14df00025f68fb2613a92d [diff]
Update account full name when it changes in LDAP

The LdapRealm declares the FULL_NAME as a read-only account field and
the read-only policy is enforced when update request comes via the
REST API [1].

However, the same read-only policy was also enforced in the
AccountManager code which is actually executed after we authenticate a
user against LDAP. Thus, if someone's name changes in LDAP, Gerrit
rejected to update the full name of that user on the next login. We
already had several such cases and had to update the full name manually
in the All-Users repository. I believe that we should accept the (new)
full name as returned by LDAP and unconditionally update it in Gerrit.

[1] https://gerrit.googlesource.com/gerrit/+/52ac1dacc728af2658b9c8cd1a48607956ee9939/java/com/google/gerrit/server/restapi/account/PutName.java#86

Bug: Issue 12844
Change-Id: I9bf7187c9302fa8e24e724b497cdd9a05e6e2b00
4 files changed
tree: 82d7c2507e1951d749a0339940a960d27e81223b
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. e2e-tests/
  6. gerrit-gwtdebug/
  7. gerrit-gwtui/
  8. gerrit-gwtui-common/
  9. gerrit-plugin-gwtui/
  10. java/
  11. javatests/
  12. lib/
  13. plugins/
  14. polygerrit-ui/
  15. prolog/
  16. prologtests/
  17. proto/
  18. resources/
  19. tools/
  20. webapp/
  21. .bazelignore
  22. .bazelproject
  23. .bazelrc
  24. .bazelversion
  25. .editorconfig
  26. .git-blame-ignore-revs
  27. .gitignore
  28. .gitmodules
  29. .gitreview
  30. .mailmap
  31. .pydevproject
  32. .zuul.yaml
  33. BUILD
  34. COPYING
  35. INSTALL
  36. Jenkinsfile
  37. package.json
  38. README.md
  39. SUBMITTING_PATCHES
  40. version.bzl
  41. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.