Google Git
Sign in
gerrit / gerrit / c3369381bf6079029db7553c0c8a2ab7bd7a6b63
commitc3369381bf6079029db7553c0c8a2ab7bd7a6b63[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Thu Mar 14 11:01:50 2024 +0000
committerEdwin Kempin <ekempin@google.com>Thu Mar 14 11:06:48 2024 +0000
tree1e39620ecddacf9494be9be53ca5384aa9c1bb54
parentaa05e6aeb64ae8b9e695f3616cceb93bd77d26b8 [diff]
ChangeInfo: Add new field that contains the current patch set number

For PostReview the web UI currently always requests revision information
to learn about new revisions that have been uploaded concurrently
(uploaded since the change screen was last reloaded). If no revision has
been uploaded concurrently the revision data is computed unnecessarily
since the revision data that is returned is already known to the web UI
(the revision data never changes as result of a PostReview request).
Returning the current revision number allows the web UI to request the
revision data only if needed. Now the web UI can skip requesting
revision information on PostReview and then use the returned current
revision number to check whether revision data needs to be reloaded
(i.e. do a full reload of the change screen if the returned current
revision is not known yet).

Not requesting revision data on PostReview will speed up the Send Reply
latency, since the expensive loading of revision data no longer needs to
be done (e.g. computing parent data is expensive). Adapting the web UI
to not request revision data on PostReview and using the returned
current revision number instead to decide if a full change reload should
be done, will be done in a follow-up change.

The new field is named 'current_revision_number', rather than
'current_patch_set_id', to keep the naming consistent with the existing
'current_revision' field.

The web UI could also use the existing 'current_revision' field, but
this field is only set if the current revision or all revisions are
requested (since populating it requires loading the patch sets). Since
we want to skip requesting revision data, we need the new
'current_revision_number' field which is always populated. Populating
the new 'current_revision_number' field is cheap, since the current
patch set ID is available in the Change entity.

So far PostReview returned the updated ChangeInfo only when list changes
options were requested. Getting to know the current revision number is
also useful when no list changes options are requested, hence change
PostReview to always return the updated ChangeInfo.

Bug: Google b/325070428
Release-Notes: Added new current_revision_number field to ChangeInfo that contains the current patch set number
Change-Id: I30f69f638f1fd99156d8274550eceb4ca908cf10
Signed-off-by: Edwin Kempin <ekempin@google.com>
6 files changed
tree: 1e39620ecddacf9494be9be53ca5384aa9c1bb54
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .pydevproject
  30. .zuul.yaml
  31. BUILD
  32. COPYING
  33. INSTALL
  34. Jenkinsfile
  35. MODULE.bazel
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.