Google Git
Sign in
gerrit / gerrit / c27a23c06b982be8de5fe27db3c1874b21ea094b
commitc27a23c06b982be8de5fe27db3c1874b21ea094b[log] [tgz]
authorKasper Nilsson <kaspern@google.com>Fri Apr 13 10:33:29 2018 -0700
committerKasper Nilsson <kaspern@google.com>Fri Apr 13 11:34:26 2018 -0700
treea2aef324bd50b8b20bec9a0dc78e9f2096e35fb0
parent2f90615543e71d76e5e7c9f76e3ceb272ce24c7f [diff]
Rely on params change to set _lastSearchPage

Gerrit remembers the last page that contains a change-list (either a
dashboard or a page with search results) so that users can return there
with the 'u' key.

This is done by saving the last relative URL as a property at the gr-app
level.

The app relied on the 'location-changed' event to set this property, but
in some cases that event is fired before the app params are set. One
such case is on a fresh reload of a search page.

In that case, the _handleSearchPageChange function has no way of knowing
what view is currently loaded, and prematurely exits.

With this change, Gerrit now observes the app params to set the
property.

Bug: Issue 7368
Change-Id: I62ead340677d9a416a4713ff003fc3ef18d3624f
2 files changed
tree: a2aef324bd50b8b20bec9a0dc78e9f2096e35fb0
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. gerrit-gwtdebug/
  6. gerrit-gwtui/
  7. gerrit-gwtui-common/
  8. gerrit-plugin-gwtui/
  9. java/
  10. javatests/
  11. lib/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. resources/
  17. tools/
  18. webapp/
  19. .bazelproject
  20. .editorconfig
  21. .git-blame-ignore-revs
  22. .gitignore
  23. .gitmodules
  24. .mailmap
  25. .pydevproject
  26. BUILD
  27. COPYING
  28. INSTALL
  29. README.md
  30. SUBMITTING_PATCHES
  31. version.bzl
  32. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.