| commit | c0ee16db36385cb77fc891ec9418a5674030ece0 | [log] [tgz] |
|---|---|---|
| author | Ivan Frade <ifrade@google.com> | Mon Jul 29 10:57:49 2024 +0300 |
| committer | Ivan Frade <ifrade@google.com> | Mon Jul 29 11:09:01 2024 +0300 |
| tree | 1afa44de84ee13c10a5375d69f0300d9dbfb26ad | |
| parent | 14ebec6c05c68be0606ea6dcc985ddd9090cc709 [diff] |
Avoid unnecessary unboxing in AutoValue If the property is a primitive int and the setter an Integer, AutoValue does an automated unboxing. Besides the unnecessary work, this can also be problematic with null values (which would throw in the unboxing). Replace the "Integer" parameter in setters with "int" when the property has the primitive type. Release-Notes: skip Change-Id: Ie93f8f1b54088bc60040b20f5a4f9a9164f79151
diff --git a/java/com/google/gerrit/server/comment/CommentContextKey.java b/java/com/google/gerrit/server/comment/CommentContextKey.java index ce9aa78..2ba74cc 100644 --- a/java/com/google/gerrit/server/comment/CommentContextKey.java +++ b/java/com/google/gerrit/server/comment/CommentContextKey.java
@@ -64,7 +64,7 @@ public abstract Builder patchset(Integer patchset); - public abstract Builder contextPadding(Integer numLines); + public abstract Builder contextPadding(int numLines); public abstract CommentContextKey build(); }
diff --git a/java/com/google/gerrit/server/patch/gitfilediff/GitFileDiffCacheKey.java b/java/com/google/gerrit/server/patch/gitfilediff/GitFileDiffCacheKey.java index 2e18e93..d127817 100644 --- a/java/com/google/gerrit/server/patch/gitfilediff/GitFileDiffCacheKey.java +++ b/java/com/google/gerrit/server/patch/gitfilediff/GitFileDiffCacheKey.java
@@ -87,7 +87,7 @@ public abstract Builder newFilePath(String value); - public abstract Builder renameScore(Integer value); + public abstract Builder renameScore(int value); public Builder disableRenameDetection() { renameScore(-1);