| commit | c0e7ecc89be79919e58e144713579374d05a4ed6 | [log] [tgz] |
|---|---|---|
| author | Youssef Elghareeb <ghareeb@google.com> | Tue Mar 16 14:01:13 2021 +0100 |
| committer | Youssef Elghareeb <ghareeb@google.com> | Wed Mar 17 10:31:34 2021 +0100 |
| tree | 51a2d1ff531dce0924b997cd612833586e93c503 | |
| parent | 586d48f57e1b6d56c647042327b1e49609705cc1 [diff] |
Add timeout to DiffOperations The odd diff cache - PatchListCache - had a timeout implemented in its PatchListLoader. This change adds the same timeout to DiffOperations - the interface using the new diff cache. PatchListLoader uses the histogram diff algorithm by default, and if it times out, the cache loader falls back to using the algorithm without myers diff, hence doing the computation faster - check [1]. This is done silently with a warning log message. In the new diff cache, the diff algorithm is part of the cache key, and accordingly in this change, the timeout exception is propagated from DiffOperations to callers. It's up to callers to request the diff again with another diff algorithm. The timeout employed by this change is implemented outside the cache, i.e. in DiffOperations. A slight change to the documentation at [2] is to be made in a future change (after fully deploying the new cache) to highlight the new behaviour. [1] https://gerrit.googlesource.com/gerrit/+/ec0f7eae9d6d067e9868d7f9177c6b2f7bcf196d/java/com/google/gerrit/server/patch/filediff/PatchListLoader.java#549 [2] https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#cache.diff.timeout Change-Id: I87d2b01b208db8648648a87d03eeb62e88c81607
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.