commit c02facbd0fd1c46d445bff5bd057048a8cfdbd53
author Ben Rohlfs <brohlfs@google.com> Fri Jan 27 18:46:02 2023 +0100
committer Ben Rohlfs <brohlfs@google.com> Mon Jan 30 11:28:35 2023 +0100
tree a9eec69c48939fe7004ab55b718cb0e9c8f8c28c
parent b57102ffa562ac74079928fba30d58b6abe3b2b1

Stop double encoding in the URL

Also stop encoding @. This will make URLs more readable.

Consistently don't encode /. This was enabled by earlier changes that
make sure that all route pattern are regular expressions. The special
:param matching of page.js did not work with `/` chars.

Release-Notes: skip
Change-Id: I15f864505811fa2c04cfb5bbb00b643464f40f3c

polygerrit-ui/app/models/views/change.ts

diff --git a/polygerrit-ui/app/models/views/change.ts b/polygerrit-ui/app/models/views/change.ts
index a206037..153777f 100644
--- a/polygerrit-ui/app/models/views/change.ts
+++ b/polygerrit-ui/app/models/views/change.ts
@@ -196,7 +196,7 @@
     childView: ChangeChildView.DIFF,
   });
 
-  const path = `/${encodeURL(state.diffView?.path ?? '', true)}`;
+  const path = `/${encodeURL(state.diffView?.path ?? '')}`;
 
   let suffix = '';
   // TODO: Move creating of comment URLs to a separate function. We are
@@ -226,7 +226,7 @@
     patchNum: obj.patchNum ?? EDIT,
   });
 
-  const path = `/${encodeURL(state.editView?.path ?? '', true)}`;
+  const path = `/${encodeURL(state.editView?.path ?? '')}`;
   const line = state.editView?.lineNum;
   const suffix = line ? `#${line}` : '';
 
@@ -242,7 +242,7 @@
   if (range.length) range = '/' + range;
 
   let repo = '';
-  if (state.repo) repo = `${encodeURL(state.repo, true)}/+/`;
+  if (state.repo) repo = `${encodeURL(state.repo)}/+/`;
 
   return `${getBaseUrl()}/c/${repo}${state.changeNum}${range}`;
 }