| commit | be9b2166a72d792b0b789d7b208c0a242058f971 | [log] [tgz] |
|---|---|---|
| author | Youssef Elghareeb <ghareeb@google.com> | Wed Jan 18 17:16:55 2023 +0100 |
| committer | Youssef Elghareeb <ghareeb@google.com> | Wed Feb 08 15:56:44 2023 +0100 |
| tree | 82e3d3915f59745b4bb058c92e2f515af92afb77 | |
| parent | 3a205ae19ff0ec08e2f666c51b8df4adfcbc0f5e [diff] |
Add a non_contributor arg to the label predicate We implement a new arg for the label predicate that works for submit requirement expressions as follows: * label:Code-Review=+2,user=non_contributor The operator matches with the change if it had a CR+2 vote on the latest patchset from a gerrit account that's not the uploader, author or committer of the latest patchset. -- Why we are adding this arg? We encountered a use case where users commit code but a bot uploads the change to gerrit on their behalf. Currently, we only support the `label:CR+2,user=non_uploader` operator, which in this case will ignore a CR+2 by the bot but doesn't prevent the actual human author from +2'ing themselves. Alternative considered: we considered adding a `label:CR+2,user=non_committer` but decided not to move with this alternative. The reason is that a maintainer can easily bypass the CR requirement by submitting code with a random email address and uploading it with their gerrit account, hence becoming able to +2 themselves. That is, it opens the door for unilateral changes. -- Why implementing as submit-requirement operator only? For two reasons: 1) This feature was only requested for submit expressions. We doubt that this will be valuable for change queries. 2) author/committer are stored in the git commit object and do not necessarily need to have a gerrit account associated with them. To evaluate the new operator we need to query for an Account ID for the author/committer of the change and match them against the label votes on the change. The logic for indexed fields is in ChangeField.java which does not have access to the account query provider, hence we can't easily add this. Release-Notes: skip Google-Bug-Id: b/260086939 Change-Id: I13a195b6b6554ccc39dd66101053dfddb8d90053
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.